Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further log tidy #5169

Merged
merged 5 commits into from
Sep 30, 2022
Merged

Further log tidy #5169

merged 5 commits into from
Sep 30, 2022

Conversation

oliver-sanders
Copy link
Member

Built on #5081
Addresses #3647

Follow on from #5081, tidy up some additional logging.

  1. Remove the "CRITICAL" log message for failed tasks.
    • Task failure is logged either two or three times.
    • If the failure is a problem we will get a "did not complete required outputs" message at a higher level.
 2022-09-29T08:49:27Z INFO - [20191209T1200Z/foot running job:01 flows:1] => failed
-2022-09-29T08:49:27Z CRITICAL - [20191209T1200Z/foot failed job:01 flows:1] failed
 2022-09-29T08:49:27Z WARNING - [20191209T1200Z/foot failed job:01 flows:1] did not complete required outputs: ['succeeded']
  1. Bump "Incomplete tasks" messages from WARNING to ERROR
    • Incomplete outputs require operator intervention to overcome.
    • This represents an error in graph execution.
    • This should be made prominent in the GUI.
- 2022-09-29T08:49:27Z WARNING - [20191209T1200Z/foot failed job:01 flows:1] did not complete required outputs: ['succeeded']
+ 2022-09-29T08:49:27Z ERROR - [20191209T1200Z/foot failed job:01 flows:1] did not complete required outputs: ['succeeded']
  1. Demote "spawned" message from INFO to DEBUG
    • Task spawning isn't really a user-facing concept, it's an internal implementation detail.
    • Spawned tasks will immediately omit a => waiting message anyway so it's duplicate information.
-2022-09-29T08:49:27Z INFO - [20191209T0900Z/foo_start waiting(runahead) job:00 flows:1] spawned
 2022-09-29T08:49:27Z INFO - [20191209T0900Z/foo_start waiting(runahead) job:00 flows:1] => waiting

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PRs raised to both master and the relevant maintenance branch.

MetRonnie and others added 4 commits September 28, 2022 14:06
* Strip some duplicate logging.
* Demote "spawned" messages from INFO to DEBUG
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Significantly cleaner log files now 👍

I'll apply the small test fix to the branch myself, and merge. One review will do (it only affects logs...)

tests/functional/spawn-on-demand/11-abs-suicide.t Outdated Show resolved Hide resolved
@hjoliver hjoliver merged commit 0f33706 into cylc:master Sep 30, 2022
@oliver-sanders oliver-sanders deleted the further-log-tidy branch September 30, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants