db: add flow nums to task jobs table #5259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
20221201T1534--8.0.x--add_flow_nums_to_task_jobs_table
branch
from
840d70a
to
eb2c876
Compare
wxtim
changed the title
|
Has something weird happened to the rebase? I'm seeing another pr's changes in here. |
Yes - I forgot to change this to being a PR against 8.0.x rather than master. |
wxtim
force-pushed
the
20221201T1534--8.0.x--add_flow_nums_to_task_jobs_table
branch
from
25cbccd
to
fe62abb
Compare
wxtim
force-pushed
the
20221201T1534--8.0.x--add_flow_nums_to_task_jobs_table
branch
3 times, most recently
from
7657cc3
to
22ba527
Compare
wxtim
changed the title
wxtim
force-pushed
the
20221201T1534--8.0.x--add_flow_nums_to_task_jobs_table
branch
from
64150dd
to
0cd811b
Compare
response to review
wxtim
force-pushed
the
20221201T1534--8.0.x--add_flow_nums_to_task_jobs_table
branch
from
0cd811b
to
4694fb0
Compare
|
wxtim
force-pushed
the
20221201T1534--8.0.x--add_flow_nums_to_task_jobs_table
branch
from
fa5cc8f
to
07de574
Compare
oliver-sanders
changed the title
oliver-sanders
requested changes
Dec 12, 2022
There was a problem hiding this comment.
This fails when trying to upgrade a real workflow:
$ git checkout upstream/master
$ cylc play foo
$ cylc stop foo
$ git checkout tim/.....
$ cylc play -n foo
...
ERROR - An error occurred when writing to the database,
...
sqlite3.OperationalError: table task_jobs has 16 columns but 15 values were supplied
… of github.com:wxtim/cylc into 20221201T1534--8.0.x--add_flow_nums_to_task_jobs_table * '20221201T1534--8.0.x--add_flow_nums_to_task_jobs_table' of github.com:wxtim/cylc: fixup fixed tests
oliver-sanders
approved these changes
Dec 12, 2022
8 tasks
wxtim
deleted the
20221201T1534--8.0.x--add_flow_nums_to_task_jobs_table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5252
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.