Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert old clock triggers to wall_clock xtriggers. #5291

Merged
merged 6 commits into from
Apr 1, 2023

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Jan 9, 2023

Close #5285

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened Update old-style clock-trigger warning. cylc-doc#575
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

Covered by existing tests:

$ git grep 'clock-trigger' tests/*functional
tests/flakyfunctional/events/40-stall-despite-clock-trig/flow.cylc:        clock-trigger = t1(P0D)
tests/flakyfunctional/special/04-clock-triggered/flow.cylc:        clock-trigger = clock{% if OFFSET is defined %}({{OFFSET}}){% endif %}
tests/functional/clock-trigger-inexact/00-big-offset/flow.cylc:# Test clock-trigger offset involving inexact intervals (months and years),
tests/functional/clock-trigger-inexact/00-big-offset/flow.cylc:        clock-trigger = baz({{OFFSET}})  # old-style clock-triggered task
tests/functional/cylc-config/00-simple/section1.stdout:    clock-trigger =
tests/functional/cylc-show/clock-triggered-non-utc-mode/flow.cylc:        clock-trigger = foo(PT5M)
tests/functional/runahead/release-update/flow.cylc:        clock-trigger = foo(P0Y)
tests/functional/special/07-clock-triggered-360.t:grep_ok "WorkflowConfigError: clock-trigger tasks require \[scheduling\]cycling mode=" \
tests/functional/special/clock-360/flow.cylc:        clock-trigger = clock(0)
tests/functional/validate/35-pass-special-tasks-non-word-names.t:        clock-trigger = t-1, t+1, t%1, t@1
tests/functional/validate/37-special-implicit-task.t:        clock-trigger = foo(PT0M)

@hjoliver hjoliver added this to the cylc-8.2.0 milestone Jan 9, 2023
@hjoliver hjoliver self-assigned this Jan 9, 2023
@hjoliver
Copy link
Member Author

Two functional tests deleted because they only tested cylc show output for old-style clock-triggers.

@hjoliver hjoliver marked this pull request as ready for review January 10, 2023 10:13
@oliver-sanders
Copy link
Member

That was quick!

Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, tested as working.


Clock-trigger tasks (see :ref:`ClockTriggerTasks`) wait on a wall
Clock-triggered tasks (see :ref:`ClockTriggerTasks`) wait on a wall
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to remove the ClockTriggerTasks section of the docs along with this.

cylc/flow/scripts/show.py Outdated Show resolved Hide resolved
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just codecov falling over as is its wont)

hjoliver and others added 2 commits April 2, 2023 09:58
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
@hjoliver hjoliver merged commit 57486ee into cylc:master Apr 1, 2023
@hjoliver hjoliver deleted the old-clock-to-xtrig branch April 1, 2023 22:37
@hjoliver hjoliver mentioned this pull request Apr 5, 2023
8 tasks
@MetRonnie MetRonnie added the schema change Change to the Cylc GraphQL schema label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
schema change Change to the Cylc GraphQL schema
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clock-triggers: re-implement as xtriggers
3 participants