deps: remove aiofiles #5308
Merged
deps: remove aiofiles #5308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Aiofiles is a simple wrapper for a thread pool executor. We don't need a 3rd party library to do this for us. * Closes cylc#5306
oliver-sanders
force-pushed
the
drop-aiofiles
branch
from
414368f to
9cf4db9
Compare
MetRonnie
approved these changes
Jan 18, 2023
datamel
reviewed
Jan 18, 2023
Comment on lines
-655
to
-662
| async for line in cont: | ||
| key, value = [item.strip() for item in line.split("=", 1)] | ||
| # BACK COMPAT: contact pre "suite" to "workflow" conversion. | ||
| # from: | ||
| # Cylc 8 | ||
| # remove at: | ||
| # Cylc 8.x | ||
| data[key.replace('SUITE', 'WORKFLOW')] = value |
There was a problem hiding this comment.
Will removing this catch anyone out?
There was a problem hiding this comment.
It was a duplicate of what was already in load_contact_file() so not actually removed
There was a problem hiding this comment.
I've replaced this with the sync load_contact_file interface run inside a thread via make_async.
datamel
approved these changes
Jan 18, 2023
|
Flaky tests failing with a codecov upload so unrelated to this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.