Avoid creating task proxies #5316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* There is a significant overhead to initiating a `TaskProxy` object. * Avoid doing this where it is not necessary. * In my test with the example in cylc#5315 with `-s TASKS=15 -s CYCLES=1` this reduced the time taken by `expand_graph_window` by ~38% from from 12.2s to `7.54`.
oliver-sanders
requested review from
wxtim and
MetRonnie
and removed request for
wxtim
dwsutherland
approved these changes
Jan 20, 2023
| @@ -651,7 +651,7 @@ def generate_definition_elements(self): | |||
| self.parents = parents | |||
|
|
|||
| def increment_graph_window( | |||
| self, itask, edge_distance=0, active_id=None, | |||
| self, itask, pool, edge_distance=0, active_id=None, | |||
There was a problem hiding this comment.
The pool is available via self.schd by the way.
8 tasks
|
Have put up a PR .. it partially supersedes this one: Will run profiling on it, but should be a vast improvement |
|
|
|
Superseded by #5319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the impact of #5315 a bit.
TaskProxyobject.with
-s TASKS=15 -s CYCLES=1this reduced the time taken byexpand_graph_windowby ~38% from from 12.2s to7.54.Also avoid duplicate
get_platformcalls.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.