Fix a bug preventing cylc vip --workflow-name=foo from working.
#5349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
fix_--workflow-name=bug
branch
from
3415bbe
to
16b00c5
Compare
datamel
reviewed
Feb 8, 2023
|
`--workflow-name foo` was fine. Caused by removal of unwanted sys.argv for Cylc VIP not removing items not exactly matching items in the Command line options arguments.
wxtim
force-pushed
the
fix_--workflow-name=bug
branch
from
16b00c5
to
0698f5c
Compare
datamel
approved these changes
Feb 14, 2023
|
Reproduced the bug and confirmed that this fixes it. |
oliver-sanders
approved these changes
Feb 16, 2023
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Feb 17, 2023
…lc into fix_localhost_platform_matching * 'fix_localhost_platform_matching' of github.com:wxtim/cylc: Fix a bug preventing `cylc vip --workflow-name=foo` from working. (cylc#5349) fix no rose vars in cylc view (cylc#5367) Cylc lint fixes (cylc#5363) data store: support unsatisfied ext_trigger fix mypy fail caused by python/mypy#13969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--workflow-name foowas fine.Caused by removal of unwanted sys.argv for Cylc VIP not removing items not exactly matching items in the Command line options arguments.
This is a small fix for a bug without an issue.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.CHANGES.mdentry included if this is a change that can affect usersCylc-Docnot req'd?.?.xbranch.