Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set-verbosity GraphQL bug #5384

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Fix set-verbosity GraphQL bug #5384

merged 2 commits into from
Feb 28, 2023

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Feb 28, 2023 •
edited
Loading

Closes #5380

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • CHANGES.md entry included if this is a change that can affect users
  • No docs needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added bug Something is wrong :( small labels Feb 28, 2023
@MetRonnie MetRonnie added this to the cylc-8.1.3 milestone Feb 28, 2023
@MetRonnie MetRonnie self-assigned this Feb 28, 2023
@MetRonnie
Copy link
Member Author

Just codecov upload failing

oliver-sanders
oliver-sanders approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@oliver-sanders oliver-sanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

hjoliver
hjoliver approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hjoliver hjoliver merged commit 37e7d22 into cylc:8.1.x Feb 28, 2023
@MetRonnie MetRonnie deleted the set-verbosity branch March 1, 2023 10:21
@MetRonnie MetRonnie linked an issue Mar 1, 2023 that may be closed by this pull request
set-verbosity bug #5380
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

@hjoliver hjoliver hjoliver approved these changes

@wxtim wxtim Awaiting requested review from wxtim

Assignees

@MetRonnie MetRonnie

Labels
bug Something is wrong :( small
Projects
None yet
Milestone
cylc-8.1.3
Development

Successfully merging this pull request may close these issues.

set-verbosity bug
3 participants
@MetRonnie @hjoliver @oliver-sanders