-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add share/lib/python and share/bin to PYTHONPATH & PATH #5525
add share/lib/python and share/bin to PYTHONPATH & PATH #5525
Conversation
bbae847
to
7a3512a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One trivial spelling fix suggested.
|
||
cat > "${CYLC_WORKFLOW_SHARE_DIR}/bin/myscript.sh" <<__HERE__ | ||
#!/usr/bin/bash | ||
echo "A sure cure for seasickness is to sit under a tree." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that one large wave might cure seasickness (and all other illnesses) in a rather permanent way for sailors on that.
(P.S. It's a Spike Milligan quote - I'm running through all the SFW (It's a smallish list) SM quotes I can find for tests today)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hjoliver that is an insanely niche reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test failure is for |
Make the bin and share dirs fix remote clean test Update tests/functional/jobscript/01-share-lib-bin/flow.cylc Co-authored-by: Hilary James Oliver <hilary.j.oliver@gmail.com>
17a3503
to
838d40d
Compare
I was working on my home PC at that point and couldn't test my fix locally - apparently my ability to imitate the output of |
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Closes #5396
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).CHANGES.md
entry included if this is a change that can affect users?.?.x
branch.