Allow pre configure plugin to access compat mode info in cylc install. #5582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
fix.make_compat_mode_info_available_before_pre_config_plugins
branch
from
979999b
to
a813c05
Compare
Show "real" args used by Cylc Play in VIP
wxtim
force-pushed
the
fix.make_compat_mode_info_available_before_pre_config_plugins
branch
from
a813c05
to
040e0f4
Compare
wxtim
commented
Jun 13, 2023
| @@ -111,5 +113,5 @@ def main(parser: COP, options: 'Values', workflow_id: Optional[str] = None): | |||
| ) | |||
|
|
|||
| set_timestamps(LOG, options.log_timestamp) | |||
| log_subcommand('play', workflow_id) | |||
| log_subcommand(*sys.argv[1:]) | |||
There was a problem hiding this comment.
Technically off-topic, but it's a very small enhancement.
8 tasks
oliver-sanders
approved these changes
Jun 14, 2023
MetRonnie
reviewed
Jun 14, 2023
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
MetRonnie
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Show "real" args used by Cylc Play in VIP)
Part fixes a bug spotted by a user and not documented as a separate ticket: Cylc install behaviour was inconsistent between
cylc installandcylc vipin the example described in cylc/cylc-rose#230 becausecylc installdid not set thecylc7_compat_modeuntil after the pre_configure plugin ran.Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.