Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial runahead limit, for offset recurrence start #5708

Merged
merged 5 commits into from
Aug 29, 2023

Conversation

hjoliver
Copy link
Member

@hjoliver hjoliver commented Aug 26, 2023

Close #5705

When computing the runahead limit at start-up (before the task pool is loaded), recurrence start points beyond the limit have to be ignored.

Getting this right for "max cycles" limits (e.g. P3 in integer or datetime cycling, as opposed to PT3H in datetime cycling) requires counting sequence points for all sequences.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@hjoliver hjoliver added the bug Something is wrong :( label Aug 26, 2023
@hjoliver hjoliver added this to the cylc-8.2.2 milestone Aug 26, 2023
@hjoliver hjoliver self-assigned this Aug 26, 2023
@hjoliver hjoliver force-pushed the fix-initial-rhlimit branch 3 times, most recently from 4b3d79f to 92c2a62 Compare August 27, 2023 02:57
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Reproduced Bug
  • Read changes
  • Checked out new tests - ensure failure against master.
  • Checked out whole branch - test pass, played with code.

@wxtim wxtim merged commit 3bccf00 into cylc:8.2.x Aug 29, 2023
25 checks passed
@hjoliver hjoliver deleted the fix-initial-rhlimit branch August 29, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :(
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants