-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cylc show satisfied xtriggers info #5780
Fix cylc show satisfied xtriggers info #5780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, and seems to work.
I wonder if Oliver's new test framework in #5731 might allow us to test it. I might have a play - since that'll help with this and be good reviewing of that PR>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, working. Might be useful to add a type annotation here
--- a/cylc/flow/data_store_mgr.py
+++ b/cylc/flow/data_store_mgr.py
@@ -482,5 +484,5 @@ class DataStoreMgr:
for state in TASK_STATUSES_ORDERED
}
- self.xtrigger_tasks = {}
+ self.xtrigger_tasks: Dict[str, Set[Tuple[str, str]]] = {}
# Managed data types
self.data = {
That's just for Tui and at present Tui doesn't support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but might as well add the suggested type annotation @dwsutherland
4473e3e
to
2e4b96d
Compare
Done. |
closes #5683
Check List
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
(andconda-environment.yml
if present).?.?.x
branch.