Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test.sim mode changes on restart #5789

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Oct 25, 2023

Closes #5781

There is some debate on the ticket about what action Cylc should take if if run_mode != og_run_mode - it probably makes sense to discuss that on #5781 - but the rest of the logic can be reviewed.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

Raise an exception if the user tries to change mode.
@wxtim wxtim force-pushed the test.sim_mode_changes_on_restart branch from 06ef772 to 559a7c7 Compare October 25, 2023 10:24
@wxtim wxtim self-assigned this Oct 25, 2023
@wxtim wxtim added this to the cylc-8.2.3 milestone Oct 25, 2023
@wxtim wxtim added bug? Not sure if this is a bug or not POC Proof of Concept labels Oct 25, 2023
@wxtim wxtim marked this pull request as draft October 25, 2023 10:38
@wxtim wxtim marked this pull request as ready for review October 25, 2023 12:29
@wxtim wxtim requested a review from hjoliver October 25, 2023 12:30
@oliver-sanders oliver-sanders modified the milestones: cylc-8.2.3, cylc-8.2.4 Nov 1, 2023
@markgrahamdawson markgrahamdawson merged commit d0cdbc2 into cylc:8.2.x Dec 7, 2023
23 of 25 checks passed
@wxtim wxtim deleted the test.sim_mode_changes_on_restart branch December 11, 2023 15:59
@MetRonnie MetRonnie linked an issue Dec 12, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug? Not sure if this is a bug or not POC Proof of Concept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run mode not conserved on restart
3 participants