Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cylc lint: add rule to catch rose date usage #5838

Merged
merged 1 commit into from
Nov 23, 2023
Merged

cylc lint: add rule to catch rose date usage #5838

merged 1 commit into from
Nov 23, 2023

Conversation

MetRonnie
Copy link
Member

@MetRonnie MetRonnie commented Nov 21, 2023 •
edited
Loading

rose date → isodatetime

Opening on 8.2.x even though this is a feature, as it's hard to see how this could be dangerous

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are included
  • CHANGES.md entry included if this is a change that can affect users
  • Add cheat sheet entry on rose date -> isodatetime cylc-doc#670
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added this to the cylc-8.2.4 milestone Nov 21, 2023
@MetRonnie MetRonnie requested a review from wxtim November 21, 2023 17:21
@MetRonnie MetRonnie self-assigned this Nov 21, 2023
@MetRonnie MetRonnie mentioned this pull request Nov 21, 2023
Merged
1 task
@wxtim wxtim merged commit 04a5b18 into cylc:8.2.x Nov 23, 2023
22 of 25 checks passed
@MetRonnie MetRonnie deleted the lint branch November 23, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxtim wxtim wxtim approved these changes

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@MetRonnie MetRonnie

Labels
small
Projects
None yet
Milestone
cylc-8.2.4
Development

Successfully merging this pull request may close these issues.
3 participants
@MetRonnie @oliver-sanders @wxtim