Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow state other run dir fix #6044

Closed

Conversation

dwsutherland
Copy link
Member

@dwsutherland dwsutherland commented Mar 29, 2024

workflow-state command and xtrigger no longer works with alternate --run-dir/cylc_run_dir:
image

This PR fixes this by passing cylc_run_dir through the required machinery.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@dwsutherland dwsutherland added the bug Something is wrong :( label Mar 29, 2024
@dwsutherland dwsutherland added this to the cylc-8.3.0 milestone Mar 29, 2024
@dwsutherland dwsutherland self-assigned this Mar 29, 2024
@dwsutherland dwsutherland force-pushed the workflow-state-other-run-dir-fix branch from f1f199a to db0b069 Compare March 29, 2024 12:09
@hjoliver
Copy link
Member

Oops - duplicate?! #6031 (Let's compare our approaches...)

@dwsutherland dwsutherland added the duplicate This is a duplicate of something else label Apr 1, 2024
@hjoliver hjoliver removed the request for review from oliver-sanders April 2, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong :( duplicate This is a duplicate of something else
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants