tutorial: make the tutorial workflow run a little slower #6047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Address feedback that the workflow runs too quickly. * Add 2-4s sleeps to slow it down. * Closes cylc#6041
MetRonnie
reviewed
Apr 3, 2024
| @@ -115,4 +116,5 @@ def main(): | |||
|
|
|||
|
|
|||
| if __name__ == '__main__': | |||
| time.sleep(2) # make the tutorial run a little slower | |||
There was a problem hiding this comment.
Based on these timings (without any sleeps) I would be tempted to make all the sleeps 4 secs so all the tasks take at least 5 secs.
Also one thing we can do to avoid sleeps on GH Actions would be (not that it matters that much)
Suggested change
| time.sleep(2) # make the tutorial run a little slower | |
| if 'CI' not in os.environ: | |
| time.sleep(4) # make the tutorial run a little slower |
|
Made my suggestions into a PR against this one: oliver-sanders#67 Also remembered people discovered an issue in the runtime configuration tutorial where part 4 "Test the |
MetRonnie
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.