Delete public DB if private DB does not exist on scheduler start #6070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MetRonnie
force-pushed
the
restart-pub-db
branch
from
50d5e49 to
ea5b691
Compare
hjoliver
approved these changes
Apr 18, 2024
oliver-sanders
approved these changes
Apr 19, 2024
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Apr 22, 2024
* upstream/master: (25 commits) Delete public DB if private DB does not exist on scheduler start (cylc#6070) Include xtrigger function signatures in `cylc config` (cylc#6071) Add Nano syntax highlighter (cylc#6072) Play should have no cylc rose options (cylc#6068) tests/integration: address urwid deprecation warning (cylc#6063) Bump dev version Prepare release 8.2.5 add mailmap entry Tutorials: avoid validation errors due to implicit tasks Update CONTRIBUTING.md Update xtrigger_mgr.py documentation Another small tweak. Tweak previous. Tutorials: increase sleep and don't sleep in CI Fix bad doctests tutorial: make the tutorial workflow run a little slower Style tweaks. Simply workflow-state code a bit. Add unit tests for workflow-state. Add to doc string. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On scheduler start, it tries to load workflow template variables from the public database. However, if the user has deleted the private database, it is not a restart, so it shouldn't try to load the public DB either.
The simple solution to this is to delete the public DB file (if it exists) immediately after checking and finding the private DB does not exist.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.?.?.xbranch.