Add "valid for" states to schema def for cylc set
#6095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dammit, good spot! We should probably have a test to assert this ---- which you've done, great. |
| @@ -2103,6 +2103,8 @@ class Meta: | |||
| - ``started`` implies ``submitted``. | |||
| - ``succeeded`` and ``failed`` imply ``started``. | |||
| - custom outputs and ``expired`` do not imply any other outputs. | |||
|
|
|||
| Valid for: paused, running, stopping workflows. | |||
There was a problem hiding this comment.
I don't think this command is really valid for stopping workflows:
Suggested change
| Valid for: paused, running, stopping workflows. | |
| Valid for: paused, running. |
There was a problem hiding this comment.
If waiting for tasks to finish while stopping, is it not valid for users to set task states? I think it can be done from the CLI
There was a problem hiding this comment.
Ooh, there is a reasonable point there due to this use case:
I need to orphan a "stuck" job submission
Which could otherwise block shutdown.
Ok, leave as is.
oliver-sanders
approved these changes
May 8, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5658
This is needed by the UI to disable mutations that are not valid for the workflow state. At present, "set" is not disabled for stopped workflows as it should be:
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.?.?.xbranch.