platforms: fix unreachable hosts not reset on platform group failure #6109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
fix.platform_selection_bug
branch
from
a476c09
to
25d6e96
Compare
oliver-sanders
changed the title
wxtim
force-pushed
the
fix.platform_selection_bug
branch
from
fc66081
to
13034d6
Compare
added test which includes break return list of all hosts consumed in a platform group.
wxtim
force-pushed
the
fix.platform_selection_bug
branch
from
13034d6
to
d30ac43
Compare
MetRonnie
reviewed
May 24, 2024
wxtim
force-pushed
the
fix.platform_selection_bug
branch
from
e166e27
to
9976751
Compare
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
wxtim
force-pushed
the
fix.platform_selection_bug
branch
from
09c0988
to
14ed16a
Compare
|
(one unused var to clean up) |
MetRonnie
reviewed
May 29, 2024
wxtim
force-pushed
the
fix.platform_selection_bug
branch
from
d2a90e0
to
b9b337f
Compare
MetRonnie
approved these changes
May 30, 2024
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
|
@oliver-sanders poke? |
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
oliver-sanders
approved these changes
Jun 11, 2024
|
Tested as working. |
Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
MetRonnie
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6100
Bad host reset was only happening if we ran out of hosts during job submission, not during preparation phase, and hosts being added to the list of bad hosts in this way were waiting for the main loop plugin to remove them.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.