Test fixes #6150
Merged
Test fixes #6150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This is testing remote-fileinstallation but the test was configured to run on hosts with shared filesystems where remote-fileinstallation is not required
* Testing job log retrieval which requires a non-shared filesystem
oliver-sanders
commented
Jun 17, 2024
| @@ -58,7 +58,7 @@ grep_ok "jumped over the lazy dog" "${TEST_NAME}.out" | |||
| # remote | |||
| TEST_NAME=${TEST_NAME_BASE}-task-status | |||
| cylc cat-log -f s "${WORKFLOW_NAME}//1/a-task" >"${TEST_NAME}.out" | |||
| grep_ok "CYLC_JOB_RUNNER_NAME=at" "${TEST_NAME}.out" | |||
There was a problem hiding this comment.
This would fail if run with anything other than an at platform e.g. _remote_background_indep_tcp
oliver-sanders
commented
Jun 17, 2024
| @@ -17,7 +17,7 @@ | |||
| #------------------------------------------------------------------------------- | |||
| # Test remote job logs retrieval, requires compatible version of cylc on remote | |||
| # job host. | |||
| export REQUIRE_PLATFORM='loc:remote' | |||
There was a problem hiding this comment.
This would fail if run on a platform with a shared filesystem e.g. _remote_background_shared_ssh.
oliver-sanders
commented
Jun 17, 2024
| @@ -17,7 +17,7 @@ | |||
| #------------------------------------------------------------------------------- | |||
| # Test reload triggers a fresh file install | |||
|
|
|||
| export REQUIRE_PLATFORM='loc:remote comms:?(tcp|ssh)' | |||
There was a problem hiding this comment.
This would fail if run on a platform with a shared filesystem e.g. _remote_background_shared_ssh.
MetRonnie
approved these changes
Jun 17, 2024
hjoliver
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple of functional tests spotted with Cylc 8.3.0 release testing.
(non-release blocker obviously, just test fixes)
These tests don't run in CI, they don't generally get run until release time.
Check the comments on each commit, make sure the fix makes sense.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.