Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task_events_mgr: handle missing job config #6326

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

task_events_mgr: handle missing job config #6326

wants to merge 1 commit into from

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Aug 23, 2024 •
edited
Loading

The solution is far from ideal, the job config info has been lost for starters, however, I think that is non-functional at this stage?

@hjoliver, any better ideas?

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • Changelog entry included if this is a change that can affect users
  • Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@oliver-sanders
task_events_mgr: handle missing job config
c33703a 
* Closes cylc#6314
* There are niche situations where the job is not stored in
  "TaskProxy.jobs".
* This handles the situation as gracefully as we are able to.
@oliver-sanders oliver-sanders added this to the 8.3.4 milestone Aug 23, 2024
@oliver-sanders oliver-sanders self-assigned this Aug 23, 2024
@oliver-sanders oliver-sanders mentioned this pull request Aug 23, 2024
Open
@oliver-sanders oliver-sanders modified the milestones: 8.3.4, 8.3.5 Sep 11, 2024
@oliver-sanders oliver-sanders mentioned this pull request Sep 18, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjoliver hjoliver Awaiting requested review from hjoliver

At least 1 approving review is required to merge this pull request.

Assignees

@oliver-sanders oliver-sanders

Labels
bug
Projects
None yet
Milestone
8.3.5
Development

Successfully merging this pull request may close these issues.

polling/set: submitted task cannot be set to succeeded
1 participant
@oliver-sanders