Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that platform from group selection checks broadcast manager #6330

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Ensure that platform from group selection checks broadcast manager #6330

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f6caf6
Ensure that platform from group selection checks broadcast manager
wxtim Aug 27, 2024
3bb76e1
fix
wxtim Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions cylc/flow/task_job_mgr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,18 +308,17 @@ def submit_task_jobs(self, workflow, itasks, curve_auth,
use_next_platform_in_group = False
bc_mgr = self.task_events_mgr.broadcast_mgr
rtconf = bc_mgr.get_updated_rtconfig(itask)
if rtconf['platform']:
try:
platform = get_platform(
rtconf['platform'],
bad_hosts=self.bad_hosts
)
except PlatformLookupError:
pass
else:
# If were able to select a new platform;
if platform and platform != itask.platform:
use_next_platform_in_group = True
try:
platform = get_platform(
rtconf,
bad_hosts=self.bad_hosts
)
oliver-sanders marked this conversation as resolved.
Show resolved Hide resolved
except PlatformLookupError:
pass
else:
# If were able to select a new platform;
if platform and platform != itask.platform:
use_next_platform_in_group = True

if use_next_platform_in_group:
# store the previous platform's hosts so that when
Expand Down
2 changes: 1 addition & 1 deletion tests/functional/intelligent-host-selection/07-cylc7-badhost.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ workflow_run_fail "${TEST_NAME_BASE}-run" \
cylc play --no-detach "${WORKFLOW_NAME}"

grep_workflow_log_ok "${TEST_NAME_BASE}-grep-1" \
"platform: badhostplatform - initialisation did not complete (no hosts were reachable)"
"platform: badhostplatform - initialisation did not complete"

grep_workflow_log_ok "${TEST_NAME_BASE}-grep-2" "CRITICAL - Workflow stalled"

Expand Down
Loading