broadcast: fix issue with multiple namespaces #6335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
added
bug
oliver-sanders
changed the title
* Fix an issue that could cause issues when broadcasting "coerced" configurations to multiple namespaces. * Specifying the same namesapce multiple times doesn't make sense, we should strip duplicates earlier on in the process. * Closes cylc#6334
wxtim
reviewed
Aug 28, 2024
| @@ -280,8 +280,16 @@ def put_broadcast( | |||
| bad_namespaces = [] | |||
|
|
|||
| with self.lock: | |||
| for setting in settings: | |||
| for point_string in point_strings: | |||
| for setting in settings or []: | |||
There was a problem hiding this comment.
This is 3 levels nested and in theory could be looping a fair bit. Might it be a nicer read and possibly more efficient with:
from itertools import product
# ...
for setting, point_string, namespace in product(
settings or [], point_strings or [], namespaces or []
):
# ...There was a problem hiding this comment.
I don't think product is more efficient (it will still use for loops under the hood, it cannot change the number of iterations), but flattening this logic might be nicer.
I would rather avoid refactors in bugfix PRs through for risk management purposes.
wxtim
approved these changes
Aug 28, 2024
|
Additional functional review performed here: #6334 (comment) |
|
Merging with 1 1/2 reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).?.?.xbranch.