Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vestiges of authorisation layer removed in #3845 #6636

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

MetRonnie
Copy link
Member

Follow-up to #3845

This user field was being added here:

def deserialize(message: str) -> 'ResponseDict':
"""Convert a JSON message string to dict with an added 'user' field."""
# Abstract out the transport format in order to allow it to be changed
# in future.
msg = json.loads(message)
msg['user'] = getpass.getuser() # assume this is the user
return msg

and then dropped here:

def _call(self, *args, user='?', meta=None, **kwargs):
if not meta:
meta = {}
return fcn(self, *args, meta=meta, **kwargs)

without actually doing anything

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • No dependency changes
  • Tests are not needed
  • Changelog entry not needed as invisible to users
  • No docs needed
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@MetRonnie MetRonnie added this to the 8.5.0 milestone Feb 25, 2025
@MetRonnie MetRonnie self-assigned this Feb 25, 2025
Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oliver-sanders oliver-sanders merged commit f93fa7c into cylc:master Feb 26, 2025
27 checks passed
@MetRonnie MetRonnie deleted the auth branch February 26, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants