fix use of cylc install interface by rose-stem #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
20221025T1350--1.1.x--fix_use_of_cylc_install_interface
branch
from
d07261b
to
b1190bd
Compare
wxtim
force-pushed
the
20221025T1350--1.1.x--fix_use_of_cylc_install_interface
branch
2 times, most recently
from
89cee0e
to
d0bf845
Compare
wxtim
force-pushed
the
20221025T1350--1.1.x--fix_use_of_cylc_install_interface
branch
from
d0bf845
to
80b8df4
Compare
|
Should this be against 1.1.x?
When did this change (which cylc-flow PR)? |
|
No
|
|
Then the milestone should be 1.2.0 |
MetRonnie
approved these changes
Oct 26, 2022
wxtim
deleted the
20221025T1350--1.1.x--fix_use_of_cylc_install_interface
branch
wxtim
added a commit
to wxtim/cylc-rose
that referenced
this pull request
Nov 25, 2022
wxtim
added a commit
to wxtim/cylc-rose
that referenced
this pull request
Nov 25, 2022
wxtim
added a commit
to wxtim/cylc-rose
that referenced
this pull request
Nov 25, 2022
…mental_improvements_to_testing * 'master' of github.com:cylc/cylc-rose: Remove subprocess from tests (cylc#194) update stem - install interface (cylc#193) Update tests/unit/test_rose_stem_units.py response to review Update setup.cfg removed never used option Improve test coverage for Rose Stem reinstall changes to `rose-suite.conf` [tests] (cylc#178) Changed the rose stem functional tests to a more pytest-integration style. Bump rose dependency to `2.1.*` Bump dev version on master to next minor release (cylc#175) Fix changelog conflict with 1.1.x (cylc#186) Prepare release: 1.1.1 (cylc#183) Rose Stem Fixes (cylc#172) Don't pass rose variables with state ! or !! to Cylc. (cylc#171) Don't pass rose variables with state ! or !! to Cylc. (cylc#171) Bump cylc-flow dependency (cylc#173) functional tests only cleanup if succeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change with no associated Issue.
Bug description
Rose stem uses the
cylc.flow.scripts.cylc_install, but the interface of that function has changed in cylc/cylc-flow#5184Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg.