Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.3.0 #219

Merged
merged 3 commits into from
Apr 12, 2023
Merged

1.3.0 #219

merged 3 commits into from
Apr 12, 2023

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Apr 3, 2023 •
edited
Loading

@oliver-sanders oliver-sanders added this to the 1.3.0 milestone Apr 3, 2023
@oliver-sanders oliver-sanders requested a review from MetRonnie April 3, 2023 15:16
@oliver-sanders oliver-sanders self-assigned this Apr 3, 2023
@MetRonnie
Copy link
Member

I'm having a look at the test failures

@MetRonnie
Copy link
Member

MetRonnie commented Apr 4, 2023 •
edited
Loading

I don't get this one

ERROR tests/functional/test_reinstall.py::test_cylc_reinstall_run - optparse.OptionConflictError:
  option --clear-rose-install-options: conflicting option string(s): --clear-rose-install-options

or the tests/functional/test_rose_stem.py failures

May need @wxtim to have a look

@oliver-sanders
Copy link
Member Author

oliver-sanders commented Apr 4, 2023 •
edited
Loading

Oh, nasty.

I suspect the same option is specified in two places.

@wxtim
Copy link
Member

wxtim commented Apr 11, 2023 •
edited
Loading

oliver-sanders#3
Fixes this simpler breakage

The clashing options is not a Cylc Rose bug, but a pure Cylc bug: I've reproduced it on master. I have checked and not reproduced it on 8.1.x and locally installed versions.

@wxtim wxtim mentioned this pull request Apr 11, 2023
Merged
@oliver-sanders
Copy link
Member Author

Next issue is this one:

optparse.OptionConflictError: option --clear-rose-install-options: conflicting option string(s): --clear-rose-install-options

@wxtim wxtim mentioned this pull request Apr 11, 2023
Merged
8 tasks
@wxtim
Copy link
Member

wxtim commented Apr 11, 2023

Next issue is this one:

optparse.OptionConflictError: option --clear-rose-install-options: conflicting option string(s): --clear-rose-install-options

Unrelated to Cylc Rose - fix up

@oliver-sanders oliver-sanders mentioned this pull request Apr 11, 2023
Merged
8 tasks
@oliver-sanders
Copy link
Member Author

Re-running the tests, they should pass now...

@MetRonnie MetRonnie merged commit ee9c5be into cylc:master Apr 12, 2023
@oliver-sanders oliver-sanders deleted the 1.3.0 branch April 12, 2023 14:31
wxtim pushed a commit to wxtim/cylc-rose that referenced this pull request Jun 26, 2023
@oliver-sanders @wxtim
1.3.0 (cylc#219)
898c392
@MetRonnie MetRonnie modified the milestones: tmp, 1.3.0 Jul 18, 2023
wxtim added a commit to wxtim/cylc-rose that referenced this pull request Oct 9, 2023
@wxtim
Merge remote-tracking branch 'upstream/1.3.x' into feature.do_not_all…
dee1183 
…ow_--defines_no_equal

* upstream/1.3.x:
  make RoseStemVersionException print the correct missing variable (cylc#252)
  Update tests/unit/test_rose_stem_units.py
  Allow top level  settings in CLI Config (cylc#221)
  Prevent accidental manual setting of project name with -s=
  Fix flake8
  Bump dev version
  Add missing dependency on ansimarkup
  Prepare release 1.3.0
  Bump pypa/gh-action-pypi-publish from 1.8.7 to 1.8.8 (cylc#236)
  Permitted warnings about root-dir for all versions of Cylc. (cylc#231)
  Bump pypa/gh-action-pypi-publish from 1.8.6 to 1.8.7 (cylc#235)
  Bump pypa/gh-action-pypi-publish from 1.8.5 to 1.8.6 (cylc#228)
  1.3.0 (cylc#219)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
small
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-sanders @MetRonnie @wxtim