Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix.template vars section #229

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jun 1, 2023

Does not close a separate issue;

Issue

Reported by @james-bruten-mo:

Rose stem assumes that the name of the templating section is [jinja2:suite.rc]. At Rose 2 [template variables] is preferred, though the older form is kept for back compatibility. If the new form is used in the config file rose stems use of the older form will cause one of cylc-roses checks on the config to fail.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • Tests are included (or explain why tests are not needed).
  • CHANGES.md entry included if this is a change that can affect users
  • Doc changes are not needed.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

@wxtim wxtim force-pushed the fix.template_vars_section branch from 0f5cff9 to e37cac3 Compare June 1, 2023 12:14
@wxtim wxtim requested review from oliver-sanders and MetRonnie June 1, 2023 12:22
@wxtim wxtim self-assigned this Jun 1, 2023
@wxtim wxtim modified the milestones: 1.2.x, 1.3.0 Jun 1, 2023
@wxtim wxtim marked this pull request as draft June 6, 2023 13:28
@wxtim wxtim force-pushed the fix.template_vars_section branch from e37cac3 to 8ad515d Compare June 8, 2023 09:16
@wxtim wxtim force-pushed the fix.template_vars_section branch from 8ad515d to 7a430eb Compare June 8, 2023 09:41
@wxtim wxtim marked this pull request as ready for review June 8, 2023 13:08
Copy link
Member

@MetRonnie MetRonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me but I don't know how to test

@oliver-sanders
Copy link
Member

Milestone doesn't match branch, which way are we going with this one?

@oliver-sanders oliver-sanders added the bug Something isn't working label Jun 14, 2023
@wxtim wxtim modified the milestones: 1.3.0, 1.2.1 Jun 14, 2023
@wxtim wxtim merged commit 21e63f4 into cylc:1.2.x Jun 14, 2023
@wxtim wxtim deleted the fix.template_vars_section branch June 14, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants