Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Cylc option parser Options object to set up options #232

Merged
merged 4 commits into from
Jun 14, 2023
Merged

Import Cylc option parser Options object to set up options #232

merged 4 commits into from
Jun 14, 2023

Conversation

wxtim
Copy link
Member

@wxtim wxtim commented Jun 14, 2023 •
edited
Loading

for running Cylc installs.

It also fixes problems caused by changes to CLI options in Cylc.

Check List

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
  • This is a change to the test battery, which does not require tests or docs.
  • If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

IMO this is a 1-review change.

@wxtim wxtim requested a review from MetRonnie June 14, 2023 12:05
@wxtim wxtim force-pushed the Fix_tests_broken_by_Cylc_flow_interface branch from e35bd43 to f980ba8 Compare June 14, 2023 12:12
@wxtim wxtim self-assigned this Jun 14, 2023
@wxtim wxtim added this to the 1.2.1 milestone Jun 14, 2023
@wxtim wxtim added the bug Something isn't working label Jun 14, 2023
MetRonnie
MetRonnie reviewed Jun 14, 2023
View reviewed changes
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@oliver-sanders oliver-sanders mentioned this pull request Jun 14, 2023
Merged
8 tasks
wxtim and others added 3 commits June 14, 2023 14:25
@wxtim @MetRonnie
Update tests/conftest.py
21f574f 
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@wxtim @MetRonnie
Update tests/conftest.py
c784764 
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@wxtim @MetRonnie
Update tests/conftest.py
47e968e 
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
@wxtim wxtim requested a review from MetRonnie June 14, 2023 13:25
@MetRonnie MetRonnie removed the bug Something isn't working label Jun 14, 2023
@MetRonnie MetRonnie merged commit 336e6ac into cylc:1.2.x Jun 14, 2023
@wxtim wxtim deleted the Fix_tests_broken_by_Cylc_flow_interface branch June 15, 2023 08:21
wxtim added a commit to wxtim/cylc-rose that referenced this pull request Jun 26, 2023
@wxtim
Merge branch '1.2.x' of github.com:cylc/cylc-rose into HEAD
9dcb49b 
* '1.2.x' of github.com:cylc/cylc-rose:
  Tests: import Cylc option parser Options object to set up options (cylc#232)
  get correct template section from rose-suite.conf
wxtim added a commit to wxtim/cylc-rose that referenced this pull request Jun 26, 2023
@wxtim
Merge branch '1.2.x' of github.com:cylc/cylc-rose into merge_changes_…
205083c 
…from_1.2.x_→_1.3.0

* '1.2.x' of github.com:cylc/cylc-rose:
  Tests: import Cylc option parser Options object to set up options (cylc#232)
  get correct template section from rose-suite.conf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MetRonnie MetRonnie MetRonnie approved these changes

Assignees

@wxtim wxtim

Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wxtim @MetRonnie