🤖 Merge 1.4.x-sync into master #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ensure that vr picks up installed config. * Update pyproject.toml * don't display warnings about ROSE_ORIG_HOST when not relevant * updated lower pin on cylc version * de-flake test, unrelated to PR * updated test for Python 3.7 --------- Co-authored-by: Oliver Sanders <oliver.sanders@metoffice.gov.uk>
github-actions
bot
added
the
sync
wxtim
approved these changes
Nov 7, 2024
Workflow: Release stage 1 - create release PR, run: 42
|
Tests failing, probably need the cylc-flow sync PR before passing. |
Prepare release: 1.4.2
Workflow: Release stage 2 - auto publish, run: 57
🤖 Bump dev version
…_handling_of_Jinja2_error Fix test broken by Cylc 8.4 better handling of Jinja2 error
|
Additional problem - cylc/cylc-flow#6289 broke one of the new tests which was reliant on the old output format. (I'm actually surprised that change hasn't broken a load of the tests in I tried raising it as a PR, but the CI was unable to run, because the cylc-admin version system couldn't cope with the 1.4.x-sync branch name, so I've merged it to this PR. We can always revert if necessary. However, because I've now modified this branch @oliver-sanders and @MetRonnie ought both review. I've dismissed my review. |
MetRonnie
approved these changes
Nov 8, 2024
oliver-sanders
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Please do a normal merge, not squash merge.
Please fix conflicts if necessary.
Triggered by
push