Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

header: use LocalStorage for owner and deployment values #1457

Closed
oliver-sanders opened this issue Aug 31, 2023 · 4 comments · Fixed by #1503
Closed

header: use LocalStorage for owner and deployment values #1457

oliver-sanders opened this issue Aug 31, 2023 · 4 comments · Fixed by #1503
Assignees
@markgrahamdawson
Milestone
2.2.0

Comments

@oliver-sanders
Copy link
Member

See #1444 (comment)

We should also include a remove button to allow typos to be removed.
@oliver-sanders oliver-sanders added this to the 2.2.0 milestone Aug 31, 2023
@oliver-sanders oliver-sanders mentioned this issue Aug 31, 2023
Merged
6 tasks
@markgrahamdawson markgrahamdawson self-assigned this Oct 3, 2023
@markgrahamdawson
Copy link
Contributor

With regards to a remove button Ill pop it on the side (any preference as to which?) Should it clear the whole local storage variable (the whole list of server owners/deployments) or just the server owner/deployment that is currently selected @MetRonnie @oliver-sanders.

image

@MetRonnie
Copy link
Member

MetRonnie commented Oct 3, 2023 •
edited
Loading

I think it would make sense to have "x" buttons after each username (in the append-item slot)

@markgrahamdawson
Copy link
Contributor

markgrahamdawson commented Oct 4, 2023 •
edited
Loading

I think it would make sense to have "x" buttons after each username (in the append-item slot)

I'm guessing we don't want to give the user the option to delete their name under 'server owner' or the default domain...

image

@oliver-sanders
Copy link
Member Author

I'm guessing we don't want to give the user the option to delete their name under 'server owner' or the default domain...

Good thinking.

@markgrahamdawson markgrahamdawson mentioned this issue Oct 4, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markgrahamdawson markgrahamdawson

Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging a pull request may close this issue.

Ability to store & remove server owner & deployment entries in dropdowns markgrahamdawson/cylc-ui
3 participants
@markgrahamdawson @oliver-sanders @MetRonnie