Ability to store & remove server owner & deployment entries in dropdowns

[markgrahamdawson]

Closes #1457

• Added functionality for storing server owner and deployment in local storage.
• The state of the reactive array for deployments or owners is copied to a local storage variable each time it is changed.
• User can also remove values that have been stored.
• User cannot remove the initial values onLoad values.

Check List

• I have read CONTRIBUTING.md and added my name as a Code Contributor.
• Contains logically grouped changes (else tidy your branch by rebase).
• Does not contain off-topic changes (use other PRs for other changes).
• Applied any dependency changes to both setup.cfg (and conda-environment.yml if present).
• Tests are included (or explain why tests are not needed).
• CHANGES.md entry included if this is a change that can affect users
• Cylc-Doc pull request opened if required at cylc/cylc-doc/pull/XXXX.
• If this is a bug fix, PR should be raised against the relevant ?.?.x branch.

[markgrahamdawson]

When I added the 'server owner' and 'deployment' dropdowns a few weeks back I initially added some tests but then went back and removed them (they didnt get merged in). I cant remember why the tests were seen as not required.
Should I try and add some end to end tests here @MetRonnie ?

[markgrahamdawson]

There is a fair bit of duplicate code as the server owner combo box is doing the same thing as the deployment combo box - I could make a separate combobox component which can be used for both. However it doesnt look like that level of componentization would be consistent with rest of app.
@MetRonnie

[markgrahamdawson]

Im not sure this requires a changes.md entry as its really just finishing off a feature that's already implemented in #1444

[MetRonnie]

When I added the 'server owner' and 'deployment' dropdowns a few weeks back I initially added some tests but then went back and removed them (they didnt get merged in). I cant remember why the tests were seen as not required. Should I try and add some end to end tests here @MetRonnie ?

I think those tests were moved from dashboard.cy.js to header.cy.js, not removed?

Im not sure this requires a changes.md entry as its really just finishing off a feature that's already implemented in #1444

Yes, this is small enough not to need a changelog entry

[markgrahamdawson]

TODO: I could add a test to header.cy.js to check if the combobox content remains after a a page refresh - or thats its been saved to local storage if there is a good way of accessing local storage with cypress...
https://docs.cypress.io/api/commands/getalllocalstorage

[markgrahamdawson]

Probably a bit late now - but for future reference there is a Vue composable for using local storage
https://vueuse.org/core/useLocalStorage/

[MetRonnie]

Nice, I'll open an issue for investigating using that. Might be a good training day exercise

[markgrahamdawson]

There is a fair bit of duplicate code as the server owner combo box is doing the same thing as the deployment combo box - I could make a separate combobox component which can be used for both. However it doesnt look like that level of componentization would be consistent with rest of app. @MetRonnie

Ive put some of the logic into a composable I notice that the the app currently is using mixins (more of an options api solution) over composables (a composition api solution) so not sure if its consistent but it seems like a neater solution.

[MetRonnie]

Ooh, actually one more enhancement would be to store the owner/deployment when clicking the "Go" button, not just pressing enter

[MetRonnie]

Nice