Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aotf: prevent the "offset" field from being filled in #1226

Merged
merged 1 commit into from
Feb 8, 2023
Merged

aotf: prevent the "offset" field from being filled in #1226

merged 1 commit into from
Feb 8, 2023
+8 −0

Conversation

oliver-sanders
Copy link
Member

Fixes a small bug where the cutoff field is set in the broadcast form when opened from a task/family/cycle.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (why?).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

Sorry, something went wrong.

@oliver-sanders
aotf: prevent the "offset" field from being filled in

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
4c14e57 
* Closes cylc#1222
* Note this solution is hardcoded in the UI and must stay that way
  until cylc#1225 is done.
@oliver-sanders oliver-sanders added the bug Something isn't working label Feb 6, 2023
@oliver-sanders oliver-sanders added this to the 1.5.0 milestone Feb 6, 2023
@oliver-sanders oliver-sanders self-assigned this Feb 6, 2023
datamel
datamel approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@datamel datamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested as working.

@oliver-sanders oliver-sanders requested a review from wxtim February 7, 2023 13:01
wxtim
wxtim approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@wxtim wxtim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit

@wxtim wxtim merged commit fbf887b into cylc:master Feb 8, 2023
@oliver-sanders oliver-sanders deleted the 1222 branch February 8, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxtim wxtim

@datamel datamel

Assignees

@oliver-sanders oliver-sanders

Labels
bug Something isn't working small
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

Check what the cutoff field in the broadcast form is doing
3 participants
@oliver-sanders @wxtim @datamel