Use dynamic async components for workspace view tabs + 1.6.x -> master (SimpleTree view) #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* A new bare-bones live tree view not available in production mode. * Indended to serve as documentation and a guide for future view development.
Resolved Conflicts: src/store/workflows.module.js src/views/Workspace.vue
simple tree: bare-bones tree view for documentation purposes
Merging 968affd
Also fixes SimpleTree view post-vue3
wxtim
approved these changes
Jun 8, 2023
kinow
approved these changes
Jun 8, 2023
| import LogView from '@/views/Log.vue' | ||
| import AnalysisView from '@/views/Analysis.vue' | ||
|
|
||
| // Use dynamic async components for lazy loading: |
| class="h-100" | ||
| /> | ||
| </Teleport> | ||
| </template> |
MetRonnie
changed the title
Comment on lines
+65
to
+71
| const allViews = [ | ||
| { name: 'Tree', component: TreeView, icon: mdiFileTree }, | ||
| { name: 'Table', component: TableView, icon: mdiTable }, | ||
| { name: 'Graph', component: GraphView, icon: mdiGraph }, | ||
| { name: 'Log', component: LogView, icon: mdiFileDocumentMultipleOutline }, | ||
| { name: 'Analysis', component: AnalysisView, icon: mdiChartLine }, | ||
| ] |
There was a problem hiding this comment.
For the long term we should think about how to make views more "plugable". It would be helpful for this information to remain tethered with the view, perhaps in some kind of metadata / sidecar file that could be imported separately. Would be worth taking a look at how Jupyter Lab make their "views" plugable as they face a similar (but more advanced) problem here.
No need for changes, this is great for now, but something to store in the back of the mind for later work...
There was a problem hiding this comment.
Added a "pending" issue to preserve this, #1319
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to incorporate the dynamically imported SimpleTree view it seemed necessary to make all the views dynamically imported in Vue 3. Closes #1221.
I also took this opportunity to use
<Teleport>instead of the hacky solution for displaying these views in the Lumino tabs. (Hat tip to @kinow for the suggestion, it is rather nice!). Closes #1273.Sync:
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.