toolbar: add n-window-selector #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MetRonnie, this setting is preserved when you navigate back, however, I have not done anything to achieve this. Should it be implemented differently or is this ok? (note the n=1 default comes from cylc-flow not cylc-ui) |
|
It's preserved because it's querying it, right? |
|
Derp, yes, it's getting the n-window extent from the returned data 🤦 |
oliver-sanders
force-pushed
the
n-window
branch
from
a2b8e06 to
6eda79d
Compare
|
As a true end-to-end feature (i.e. flow-uis-ui-uis-flow) it's a right pain to test. I had a look a testing, at the unit test level you end up testing vue watchers and at the e2e level, you end up testing the Vuetify Select API. |
MetRonnie
reviewed
Apr 19, 2024
* Closes cylc#864 * Add a selector for switching the n-window extent between 0 & 3 inclusive. * The n-window value appears to be preserved when navigating back to the workflow.
oliver-sanders
force-pushed
the
n-window
branch
from
f49f4cc to
c5e13fb
Compare
MetRonnie
reviewed
Apr 19, 2024
oliver-sanders
commented
Apr 22, 2024
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
MetRonnie
reviewed
Apr 22, 2024
MetRonnie
approved these changes
Apr 23, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfg(andconda-environment.ymlif present).CHANGES.mdentry included if this is a change that can affect users?.?.xbranch.