Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to GitHub Actions #322

Merged
merged 4 commits into from
Dec 4, 2019
Merged

Move to GitHub Actions #322

merged 4 commits into from
Dec 4, 2019

Conversation

kinow
Copy link
Member

@kinow kinow commented Dec 1, 2019

These changes close #321

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (why? build scripts only).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

@kinow
Copy link
Member Author

kinow commented Dec 1, 2019

Draft as not sure if others will agree with the move - it would probably mean moving other projects to GitHub Actions too. Took me around 10 minutes to prepare the workflow in GitHub (I've seen people using actions, build, workflows, etc... the docs of github actions use workflows too), and another 30-40 minutes to test caching and write ticket and prepare the PR.

Shouldn't take long for cylc-uiserver and smaller projects. Probably will take a couple of days or a bit more for Cylc Flow due to functional tests. But it would allow us to use Docker containers and actions. Which, if faster on GitHub, would be a huge advantage (Docker containers can be slow to start up and provision/install required software depending on the infra).

@kinow kinow self-assigned this Dec 1, 2019
@kinow kinow added this to the 0.2 milestone Dec 1, 2019
@hjoliver
Copy link
Member

hjoliver commented Dec 1, 2019

I don't see any reason not to do this; let's make a decision in the meeting on Tuesday.

@kinow kinow marked this pull request as ready for review December 3, 2019 20:53
@kinow
Copy link
Member Author

kinow commented Dec 3, 2019

Ready for review.

Copy link
Member

@hjoliver hjoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks like nice clean setup. I'll take your word that it works. I don't think we need a 2nd review for this.

@hjoliver hjoliver merged commit d4351e9 into cylc:master Dec 4, 2019
@kinow
Copy link
Member Author

kinow commented Dec 4, 2019

Thanks @hjoliver !

Your merge here has triggered the first GitHub action :-)

https://github.com/cylc/cylc-ui/actions?query=workflow%3ACI

I have disabled the push-trigger in Travis for cylc/cylc-ui (those two options under the General text)

image

@kinow
Copy link
Member Author

kinow commented Dec 4, 2019

(first action took 3m57s, better than 7m30s from travis, but hope it will be even better now with the cache ready)

@kinow kinow deleted the try-github-actions-01 branch March 19, 2020 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to GitHub actions
2 participants