-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to GitHub Actions #322
Conversation
Draft as not sure if others will agree with the move - it would probably mean moving other projects to GitHub Actions too. Took me around 10 minutes to prepare the workflow in GitHub (I've seen people using actions, build, workflows, etc... the docs of github actions use workflows too), and another 30-40 minutes to test caching and write ticket and prepare the PR. Shouldn't take long for cylc-uiserver and smaller projects. Probably will take a couple of days or a bit more for Cylc Flow due to functional tests. But it would allow us to use Docker containers and actions. Which, if faster on GitHub, would be a huge advantage (Docker containers can be slow to start up and provision/install required software depending on the infra). |
I don't see any reason not to do this; let's make a decision in the meeting on Tuesday. |
Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks like nice clean setup. I'll take your word that it works. I don't think we need a 2nd review for this.
Thanks @hjoliver ! Your merge here has triggered the first GitHub action :-) https://github.com/cylc/cylc-ui/actions?query=workflow%3ACI I have disabled the push-trigger in Travis for cylc/cylc-ui (those two options under the General text) |
(first action took 3m57s, better than 7m30s from travis, but hope it will be even better now with the cache ready) |
These changes close #321
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.