Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin node version in github actions #592

Merged
merged 1 commit into from
Feb 11, 2021
Merged

pin node version in github actions #592

merged 1 commit into from
Feb 11, 2021

Conversation

oliver-sanders
Copy link
Member

@oliver-sanders oliver-sanders commented Feb 11, 2021 •
edited
Loading

Use the standard action to configure node to:

  • Pin the version.
  • Ensure we are using the standard setup.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (why?).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

@oliver-sanders oliver-sanders mentioned this pull request Feb 11, 2021
Closed
6 tasks
@oliver-sanders oliver-sanders changed the title . fix yarn installation issues (hopefully) Feb 11, 2021
@oliver-sanders oliver-sanders changed the title fix yarn installation issues (hopefully) pin node version in github actions Feb 11, 2021
@oliver-sanders oliver-sanders self-assigned this Feb 11, 2021
@oliver-sanders oliver-sanders added this to the 0.3 milestone Feb 11, 2021
kinow
kinow approved these changes Feb 11, 2021
View reviewed changes
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Ci happy, LGTM! Thanks

@kinow kinow merged commit 6f1dfcb into cylc:master Feb 11, 2021
@oliver-sanders oliver-sanders deleted the actions branch February 11, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinow kinow kinow approved these changes

Assignees

@oliver-sanders oliver-sanders

Labels
None yet
Projects
None yet
Milestone
0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oliver-sanders @kinow