fix websockets with webkit #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver-sanders
force-pushed
the
fix-websockets-with-webkit
branch
from
bac074c
to
08c8b3c
Compare
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 50.75% 50.75%
=======================================
Files 6 6
Lines 396 396
Branches 64 64
=======================================
Hits 201 201
Misses 192 192
Partials 3 3
Continue to review full report at Codecov.
|
kinow
approved these changes
Aug 3, 2020
| @@ -34,7 +34,8 @@ def set_default_headers(self) -> None: | |||
| self.set_header("Access-Control-Allow-Origin", "*") | |||
| self.set_header("Access-Control-Allow-Headers", "x-requested-with") | |||
| self.set_header('Access-Control-Allow-Methods', 'POST, GET, OPTIONS') | |||
| self.set_header('Server', '') | |||
| # prevent server fingerprinting | |||
| self.clear_header('Server') | |||
|
Tested locally, and works better than previous change. The server header is simply not present.
One review should be enough. |
|
Thanks @oliver-sanders ! (and sorry for creating the issue 😬 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #152
Since Google forked WebKit this primarily affects Safari.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.