Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mkdirall: inherited sgid bits error #24

Closed
cyphar opened this issue Sep 13, 2024 · 0 comments · Fixed by #25
Closed

mkdirall: inherited sgid bits error #24

cyphar opened this issue Sep 13, 2024 · 0 comments · Fixed by #25

Comments

@cyphar
Copy link
Owner

cyphar commented Sep 13, 2024 •
edited
Loading

It turns out the sgid bit is inherited from parent directories, which makes our MkdirAll mode checks fail if we create directories inside a chmod g+s directory.

See opencontainers/runc#4393 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mkdir: handle suid/sgid bits correctly cyphar/filepath-securejoin
1 participant
@cyphar