mkdir: handle suid/sgid bits correctly #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyphar
force-pushed
the
mkdirall-setid-bits
branch
from
9c0eaa8 to
d3adf68
Compare
These bits are ignored by mkdirat(2) on every POSIX system (Linux does honour the sticky bit, though it is an outlier). We could ignore them but this seems less than ideal (a user could be under the impression their code works when actually the bit is not getting set) so returning an informative error is preferable. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
S_ISGID is applied to directories created underneath it and affects the gid of all inodes created under a directory with it set. We need to handle this properly in order to avoid errors from our mode/owner validation logic. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
cyphar
force-pushed
the
mkdirall-setid-bits
branch
from
d3adf68 to
1acda83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
Fixes #24
See opencontainers/runc#4401