Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade zmq2 0.5.0 -> zmq 0.10.0 #33

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

yanganto
Copy link
Contributor

zmq2(0.5.0) and zmq-sys2(0.3.0) are in legacy and have not been in maintained for a while, and it seems zmq is the one that should be used after Sep 2, 2022.
erickt/rust-zmq#345 (comment)

@yanganto yanganto marked this pull request as draft April 12, 2024 05:23
@yanganto yanganto marked this pull request as ready for review April 12, 2024 06:13
@dr-orlovsky
Copy link
Member

Thank you, but this package is not anymore used by our software stack. Right now we do not have a nodes which are maintained, and future versions of them should use rust-netservices instead of this repo.

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 33148d1

@dr-orlovsky dr-orlovsky merged commit 3476323 into cyphernet-labs:master Apr 12, 2024
18 of 24 checks passed
@yanganto yanganto deleted the zmq branch April 12, 2024 20:22
@yanganto
Copy link
Contributor Author

yanganto commented Apr 16, 2024

The lnp-node is eventually dependent on this.

Currently, lnp-node is the only lightning node that supports RGB protocol, I think this is important so I am updating this.

If we can bounce the version to 0.9.1, I can update the rest crates (lnp-core, microservices) based on internet2 and also needed by lnp-node. 🙏

@dr-orlovsky
Copy link
Member

Currently, lnp-node is the only lightning node that supports RGB protocol, I think this is important so I am updating this.

Nope. First, it works with very old RGB version, i.e. can't be used with modern RGB assets. Second, there is a LDK-based node from Bitfinex, which is the main LN node to be used with RGB.

There is a plan to eventually update LNP node, but it will take nearly a complete node re-write, so we will be also able switch to rust-netservices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants