Validate formatting of inscriptionId in getId() function #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elocremarc
reviewed
Mar 2, 2024
| @@ -17,8 +17,8 @@ import { decode } from './content/cbor-x.mjs'; | |||
| * const myId = getId(); | |||
| */ | |||
| export const getId = () => { | |||
| let id = window.location.pathname.split('/')[2]; | |||
| return id; | |||
| let rex = /\/([a-f0-9]{64}i[0-9]{1,3})\/?/i; | |||
There was a problem hiding this comment.
Why a limit after i? The batch inscription index can be over 1000.
Suggested change
| let rex = /\/([a-f0-9]{64}i[0-9]{1,3})\/?/i; | |
| let rex = /([a-f0-9]{64}i[0-9]+)/i; |
|
@angrybirdcoiners Can add write tests for the regex function on expected URLs? Idk how to write a test in bun to actually get the window element. But we could just test the regex. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added regex to validate inscriptionId in getId() and removed positional assumption for inscriptionId