Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the order of options for account creation #1008

Merged
merged 6 commits into from
May 13, 2024

Conversation

David-Muhasa
Copy link
Contributor

Pullrequest

Issues

  • None

Checklist

  • None

How2Test

  • None

Todo

  • None

@marclaporte marclaporte requested a review from josaphatim May 7, 2024 16:50
@josaphatim
Copy link
Member

josaphatim commented May 8, 2024

@David-Muhasa If think these changes are wrong
They make modules tied. If you try to disable module wordpress you will notice that other sections in servers page will disappear as well

If think the best way to do this is:
In modules/feeds/setup.php
replace server_content_start by server_content_end and change the marker as well from after to before

In modules/nux/setup.php
Replace server_config_stepper_accordion_end_part by server_content_start

In this manner the order for sections will be

Add an E-mail Account
IMAP - JMAP - SMTP Servers
Feeds
NASA APIs
WordPress.com Connect
Github Connect

Please also handle the case when smtp, imap and jmap modules are not disabled
Hm_Output_server_config_stepper_end_part must be visible if at least one of those modules is enabled

@David-Muhasa
Copy link
Contributor Author

@josaphatim I try to put your orientation into practice and then I will come back to you

@David-Muhasa
Copy link
Contributor Author

hello @josaphatim

@David-Muhasa David-Muhasa merged commit 5b15846 into cypht-org:master May 13, 2024
6 checks passed
@marclaporte
Copy link
Member

@David-Muhasa since you are new to the project, you should not merge your own PRs, but instead let @josaphatim or another experienced dev do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants