Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement-screen-email #1132

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

christer77
Copy link
Member

@christer77 christer77 commented Jul 25, 2024

@christer77 christer77 force-pushed the implement-screen-email branch 8 times, most recently from 927e9b6 to db41eb0 Compare July 25, 2024 21:18
@josaphatim josaphatim marked this pull request as ready for review July 25, 2024 21:35
@marclaporte
Copy link
Member

I sure look forward to this feature :-)

@marclaporte marclaporte requested a review from Shadow243 July 26, 2024 03:04
Copy link
Member

@Shadow243 Shadow243 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR seems correct Thanks, just some small correction to be done

@marclaporte marclaporte requested a review from Shadow243 August 1, 2024 15:06
@christer77 christer77 force-pushed the implement-screen-email branch from db41eb0 to c900510 Compare August 5, 2024 08:02
@Baraka24 Baraka24 force-pushed the implement-screen-email branch from c900510 to 0a0838d Compare August 5, 2024 13:30
@Shadow243
Copy link
Member

everything is good for me, any suggestion @kroky ?

@marclaporte marclaporte requested a review from kroky August 6, 2024 14:45
@christer77 christer77 force-pushed the implement-screen-email branch 2 times, most recently from e39b89e to a3d322e Compare August 14, 2024 00:18
@marclaporte
Copy link
Member

@christer77 This branch has conflicts that must be resolved

@christer77 christer77 force-pushed the implement-screen-email branch 3 times, most recently from 1a3ecf5 to 9dddb71 Compare August 17, 2024 13:24
@marclaporte marclaporte requested a review from kroky August 20, 2024 00:16
@christer77 christer77 force-pushed the implement-screen-email branch 2 times, most recently from f4fbb4d to 75766a8 Compare August 22, 2024 08:59
@christer77 christer77 force-pushed the implement-screen-email branch from 75766a8 to 1d0d8c8 Compare August 23, 2024 07:00
@christer77 christer77 force-pushed the implement-screen-email branch from 1d0d8c8 to ede161b Compare August 23, 2024 07:04
@marclaporte marclaporte requested a review from kroky August 23, 2024 15:07
@kroky kroky merged commit 9a39ff2 into cypht-org:master Aug 26, 2024
6 checks passed
}
}
$res = '<tr class="general_setting"><td><label for="move_messages_in_screen_email">'.
$this->trans('Move all messages in Screen Email folder if dislike email').'</label></td><td><input class="form-check-input" type="checkbox" role="switch" id="move_messages_in_screen_email" name="move_messages_in_screen_email" '.$checked.' ></td></tr>';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Move all messages in Screen Email folder if dislike email"

Please make this clearer for a new user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screen emails (messages from previously uncategorized emails are flagged)
4 participants