Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Error message if there is a space at the beginning or end of username or password(login, nux, smtp, imap) #780

Conversation

NasserNgandu
Copy link
Contributor

Display a message if the username or password contains a space at the beginning or at the end at login, nux, smtp, imap. Here is the link to the task: https://avan.tech/item10670

modules/smtp/site.js Outdated Show resolved Hide resolved
@marclaporte
Copy link
Member

Given the task URL above is not public, I will copy some relevant info from it.

Task: Make sure copy pasting a username or password (in a login prompt) with a leading or trailing space doesn't cause a problem

This happens, and leads to support issues. Unless we think there is going to be a password with a space, it should be trimmed, or at least a warning given. (ex.: "You have a leading or trailing space")

Related links:

modules/smtp/site.js Outdated Show resolved Hide resolved
modules/smtp/site.js Outdated Show resolved Hide resolved
@marclaporte marclaporte marked this pull request as draft February 28, 2024 23:11
@josaphatim josaphatim force-pushed the Error_message_at_the_beginning_or_at_the_end branch 2 times, most recently from 740f111 to 4d413fe Compare June 21, 2024 15:57
@josaphatim josaphatim marked this pull request as ready for review June 21, 2024 15:59
@josaphatim josaphatim requested a review from Yannick243 June 28, 2024 11:15
@josaphatim josaphatim force-pushed the Error_message_at_the_beginning_or_at_the_end branch from 4d413fe to c5a565f Compare July 9, 2024 14:53
@Shadow243 Shadow243 merged commit 9bbe27d into cypht-org:master Jul 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants