Move to Bootstrap 5

[alvinBM]

Pullrequest

Move to bootstrap 5

Issues

• Move to Bootstrap 5 #762

[marclaporte]

I am thrilled there is progress here!

[marclaporte]

yay!

[kroky]

That seems like quite an effort. I added just a couple of comments. Code looks good. I think more people should test each form/table/page in Cypht to ensure it works correctly. Also, after that's merged, we need to test the Tiki integration as there might need to be some tweaks (especially if bootstrap versions are different).

[marclaporte]

At a meeting yesterday, @alvinBM indicated that future steps (in distinct PRs) include adding some themes from Bootswatch and testing the integration in Tiki.

[josaphatim]

@alvinBM I just found some points that need to be fixed.

• Login and success buttons color should be teal to make it uniform with link I guess.
• Remove css styling of .nux_password
• Add bootstrap to .credentials, .search_terms
• Test, delete, forget, hide buttons are not working anymore on /?page=servers page
• Class Hm_Image_Sources should be deleted as icons are replaced by twbs/bootstrap-icons
• Adding servers (IMAP, JMAP, SMTP) is not working
• Delete button on /?page=contacts page is not working
• Many tests are failing
• Review padding on /?page=highlights page when there is no rule yet
• Add bootstrap to Github, 2fa and Wordpress Settings (Activate those modules) then got to /?page=settings page
• Add bootstrap to 2fa authentication page

[josaphatim]

@alvinBM I think also:

• Inputs and buttons on modal Add script and add filter must also have bootstrap classes.
• Page /?page=block_list has no bootstrap yet
• On message list page:
  - Snooze button dropdown must be replaced by bootstrap dropdown
  - copy and move button are not working and must all toggle a bootstrap dropdown, our custom dropdowns must be replaced everywhere.
• On message view page:
  - Block sender button dropdown must also be replaced and its inputs must use bootstrap classes
  - In from header: there is a button that toggle a dropdown must be replaced too.
  - Next and previous buttons icons must be replaced too
• Class .unread_count must also have a .badge class
• The + sign before mailboxes that have children may also be replaced by an icon

[marclaporte]

gremlin

[alvinBM]

• Many tests are failing

I fixed most of the tests, and I noticed that others were not even linked to my PL, and even in master I have quite a few tests that fail.

[alvinBM]

Hello @marclaporte, @kroky, @josaphatim , I think that this PL is ready at this level, and as I said previously, the work of migrating to bootstrap 5 and improving the UI will be continuous work, so merging this one will allow other person who works on UI/UX to start with a new bootstrap5 base, and that will save me too many conflicts every time I try to be in sync with the master.

[kroky]

Alright, merging this and we will resolve further issues with different PRs...

[marclaporte]

Bootswatch is coming: #921