-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set circleci browser tools orb to pull v1 with updates #449
Conversation
Pin the version @1 so that non-breaking updates and fixes can be pulled in automatically as they arise.
|
@DaleGardner The tests don't appear to be running and I'm not sure why |
@jennifer-shehane My guess is that it's something to do with this being an outside collaborator contribution. All the recent pipeline runs I see are from org members. The pipelines are not even triggering so maybe the project is not set to run a pipeline for a fork? |
@DaleGardner That must be it! Updated circleci settings, let me try to commit to rerun. You forget all these little steps for newer projects. |
@jennifer-shehane Seems like you might also need the option for setting secrets for forked builds to pass the token |
@DaleGardner We don't want to expose this secret in forked builds, but I was able to trigger this to run. |
Sorry for the delay, haven't touched this repo in a while! |
@jennifer-shehane Thanks for the merge, I think you need to manually release it as well? since I still see 3.2 being the last release https://github.com/cypress-io/circleci-orb/releases |
There is a section in CONTRIBUTING > Releasing describing the manual steps necessary to release. Merging a PR apparently only triggers a |
@MikeMcC399 Yeah need to be done by maintainers |
@jennifer-shehane Could we get a release created for this? Our Cypress pipelines are not able to run without this critical fix 😢 |
|
Pin the version @1 so that non-breaking updates and fixes can be pulled in automatically as they arise.