feat: support CJS configs in ES packages #553
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
When writing an application with
"type": "module"
inpackage.json
, it becomes impossible to set the NYC config with JS, since it only supports the.js
extension and it only supports CommonJS. As a result, any configuration innyc.config.js
will fail for trying torequire
an ES module.This PR adds support for
nyc.config.cjs
, allowing packages with"type": "module"
to still configure anyc.config.cjs
file for a CommonJS configuration.