Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

need to expose browserify object not just options #28

Closed
baerrach opened this issue Nov 11, 2019 · 2 comments
Closed

need to expose browserify object not just options #28

baerrach opened this issue Nov 11, 2019 · 2 comments

Comments

@baerrach
Copy link
Contributor

  • Cypress Version:
    "@cypress/browserify-preprocessor": "^2.1.1",

Is this a Feature or Bug?

Feature

Current behavior:

There is no way to call any of the methods on the browserify object bundler created by cypress-browserify-preprocessor.

For example ignore() can't be used to work-around problems like:

Desired behavior:

Expose the bundler so that Cypress user-land code can call any methods it needs
baerrach added a commit to baerrach/cypress-browserify-preprocessor that referenced this issue Nov 11, 2019
@baerrach
feat: add decorator option to preprocessor function
a5c831e 
If the decorator function is supplied it will be called with the Browserify
instance allowing the user to call methods on the Browserify instance like
https://github.com/browserify/browserify#bignorefile

closes cypress-io#28
@baerrach baerrach mentioned this issue Nov 11, 2019
Closed
@chrisbreiding
Copy link
Collaborator

You can achieve this with the onBundle option.

@baerrach
Copy link
Contributor Author

Grr. I'm sure I checked that bundler wasn't passed into a function like that.

Cheers

@baerrach baerrach mentioned this issue Nov 12, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add decorator option to preprocessor function baerrach/cypress-browserify-preprocessor
2 participants
@baerrach @chrisbreiding