Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cypress-plugin-stripe-elements to plugins list #3442

Merged
merged 2 commits into from
Dec 29, 2020

Conversation

dbalatero
Copy link
Contributor

I created a new plugin to assist with filling Stripe Elements inputs, as this seemed to be a large-ish problem people were having!

Verified

This commit was signed with the committer’s verified signature.
joshcooper Josh Cooper
@CLAassistant
Copy link

CLAassistant commented Dec 26, 2020

CLA assistant check
All committers have signed the CLA.

@jennifer-shehane
Copy link
Member

Thanks for submitting the plugin! Please check to see if it fulfills these requirements:

  • 🚀 Works with the latest major version of Cypress
  • 🛠 Plugin purpose is clearly documented (in a README or docs website)
  • 📝 Well-written documentation - A great example (link)
  • 🔬 Tested using Cypress - tests using Cypress can act as both example usage and test coverage
  • 👷‍♀️ CI pipeline that's passing (CircleCI and Github Actions are both free for Open Source)

If you have reason to believe your plugin does not need to meet certain requirements, please feel free to provide justification.

Sorry, something went wrong.

@dbalatero
Copy link
Contributor Author

Works with the latest major version of Cypress

Yes, the test suite runs against 6.x.

Plugin purpose is clearly documented (in a README or docs website)
Well-written documentation - A great example

Yes, see README.md of the repo.

Tested using Cypress - tests using Cypress can act as both example usage and test coverage

Yes

CI pipeline that's passing (CircleCI and Github Actions are both free for Open Source)

I beat my head against the wall trying to get CircleCI to work, but every single time I do cypress run on CI, it hangs uncompleted for 10 minutes then the process is killed.

Here are multiple Cypress issues about similar problems:

Something really weird is going on in the world of Cypress + CI + (docker?) but after 6 hours of trying I gave up. It runs perfect on my Mac laptop locally, so I just have the prepublish task include yarn test as a step I take before releasing a version.

Is this ok?

@dbalatero
Copy link
Contributor Author

Oh, this is the branch I'm trying to get CircleCI working in:
dbalatero/cypress-plugin-stripe-elements#1

Thanks!

@dbalatero
Copy link
Contributor Author

@jennifer-shehane Ok, I actually got Github Actions setup and it only took like 20-30mins and a couple of pushes. This should satisfy your final requirement (CI!)

@jennifer-shehane jennifer-shehane merged commit 76b7e8a into cypress-io:develop Dec 29, 2020
@dbalatero
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants