Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document mode argument to plugins #3693

Merged
merged 9 commits into from
Mar 29, 2021

Conversation

lmiller1990
Copy link
Contributor

@lmiller1990 lmiller1990 commented Mar 15, 2021

This PR introduced some additional config options to support Component Testing: cypress-io/cypress#15526

I have updated the documentation to reflect these changes.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened a pull request for some suggested updates. #3696

@lmiller1990
Copy link
Contributor Author

lmiller1990 commented Mar 15, 2021

Thanks @jennifer-shehane. I think we should leave this open a moment, looks like there is a little more feedback around the API and implementation. mode may become a property on the second arg, config, to plugins. Let's wait and see.

I will ping you again once it's 100% finalized and the PR is merged.

EDIT: Updated for final API. Latest comment and summary.

@lmiller1990
Copy link
Contributor Author

@jennifer-shehane @amirrustam @matthamil The relevant feature was finally merged into develop: cypress-io/cypress#15526. Please review and let me know if I need to make any changes.

@amirrustam
Copy link
Contributor

This is part of v7 release, so not merging yet.

@amirrustam amirrustam dismissed jennifer-shehane’s stale review March 24, 2021 02:54

Dismissing since Jennifer's suggested updates have been merged in.

@amirrustam amirrustam changed the base branch from next-docs to master March 26, 2021 21:27
@jennifer-shehane jennifer-shehane changed the base branch from master to 7.0-release-next-docs March 29, 2021 14:03
@jennifer-shehane jennifer-shehane mentioned this pull request Mar 29, 2021
14 tasks
@jennifer-shehane jennifer-shehane merged commit e36b7dc into 7.0-release-next-docs Mar 29, 2021
@matthamil matthamil deleted the document-plugins-mode branch April 14, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants