Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update TypeScript documentation #5604

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

AtofStryker
Copy link
Contributor

updatesTypeScript documentation to display new minimum version set inCypress v13 and update changelog entry.

Also add entry on values being overridden in the users tsconfig.json in order to make their typescript files executable inside the Cypress Node.js runtime

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for benevolent-cat-040f48 ready!

Name Link
🔨 Latest commit b02b62c
🔍 Latest deploy log https://app.netlify.com/sites/benevolent-cat-040f48/deploys/65a18d5612116a0008e505b9
😎 Deploy Preview https://deploy-preview-5604--benevolent-cat-040f48.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AtofStryker
Copy link
Contributor Author

target will need to be set to whatever release cypress-io/cypress#28709 makes it into

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AtofStryker Make sure to update the base branch to a 13.x branch before merging.

{
"module": "commonjs",
"moduleResolution": "node",
"preserveValueImports": false // only applicable to TypeScript 4.5 and greater
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AtofStryker Someone left a note on a json example in our docs recently about how if you copy/paste it, it will be invalid due to the comments. I don't know if we want to update this so people don't copy/past the comment...........

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats actually a good point. ill update it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just removed it since most are on typescript 4.5 and above and likely can infer if the setting is applied or not based on their version

docs/guides/tooling/typescript-support.mdx Outdated Show resolved Hide resolved
… Cypress v13 and update changelog entry. Also add entry on values being overriden in the users tsconfig in order to make their typescript files executable inside the Cypress Node.js runtime
@AtofStryker AtofStryker force-pushed the update_typescript_documentation branch from a88093a to b02b62c Compare January 12, 2024 19:04
### Processing your Cypress configuration and plugins

Cypress needs to be able to transpile your Cypress configuration and plugins written in TypeScript in order to make them executable within Cypress' Node.js runtime.
To do this, Cypress will attempt to read the user's TypeScript and project configuration to apply the correct TypeScript loader to Cypress' Node.js runtime.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should point to where it reads this from... ie: /root/tsconfig.json etc

Copy link
Contributor

@jordanpowell88 jordanpowell88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Left a comment that could potentially use some more clarification but not a deal breaker

@AtofStryker AtofStryker changed the base branch from main to chore/release-13-6-3 January 16, 2024 20:35
@AtofStryker AtofStryker merged commit 4a3a94e into chore/release-13-6-3 Jan 16, 2024
11 checks passed
@AtofStryker AtofStryker deleted the update_typescript_documentation branch January 16, 2024 20:38
AtofStryker added a commit that referenced this pull request Jan 16, 2024
* chore: add changelog from 13.6.3

* update TypeScript documentation to display new minimum version set in Cypress v13 and update changelog entry. Also add entry on values being overriden in the users tsconfig in order to make their typescript files executable inside the Cypress Node.js runtime (#5604)

* Update docs/guides/tooling/typescript-support.mdx

Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>

---------

Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants